Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update description column to show 3 lines #5322

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ The types of changes are:
- Ignore `400` errors from Talkable's `person` endpoint. [#5317](https://github.com/ethyca/fides/pull/5317)
- Fix Email Connector logs so they use configuration key instead of name [#5286](https://github.com/ethyca/fides/pull/5286)
- Updated Responsys and Firebase Auth integrations to allow multiple identities [#5318](https://github.com/ethyca/fides/pull/5318)
- Fix Detection & Discovery descriptions to not get cut off so tightly [#5322](https://github.com/ethyca/fides/pull/5322)

### Added
- Added support for hierarchical notices in Privacy Center [#5291](https://github.com/ethyca/fides/pull/5291)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,16 @@ const useDetectionResultColumns = ({
}),
columnHelper.accessor((row) => row.description, {
id: "description",
cell: (props) => <DefaultCell value={props.getValue()} />,
cell: (props) => (
<DefaultCell
whiteSpace="normal"
my={2}
noOfLines={3}
value={props.getValue()}
/>
),
header: (props) => <DefaultHeaderCell value="Description" {...props} />,
size: 300,
}),
columnHelper.display({
id: "status",
Expand Down Expand Up @@ -134,6 +142,7 @@ const useDetectionResultColumns = ({
<DetectionItemActionsCell resource={props.row.original} />
),
header: "Actions",
size: 180,
}),
];
return { columns };
Expand Down
Loading