Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update description column to show 3 lines #5322

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update description column to show 3 lines #5322

wants to merge 2 commits into from
+11 −1

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Sep 23, 2024 •
edited
Loading

Closes PROD-2721

Description Of Changes

Longer descriptions are getting cut off pretty tightly on the D&D tables. This update gives it more breathing room.

Code Changes

  • Set width of Descriptions to 300px
  • Set description text to show 3 lines before truncating.
  • Fix Actions column by setting its width to 180px (just like we're already doing for the main D&D table)

Steps to Confirm

  • Visit Data Detection page of Admin UI.
  • Click a row to open the table
  • If the table has a description that is longer, it should show up to 3 lines before truncating and should be slightly wider than the other columns (at 300px wide)
  • If there is no description, you may have to find another table or add the text manually in the browser's dev tools.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 9:26pm

@cypress Cypress
Copy link

cypress bot commented Sep 23, 2024 •
edited
Loading

fides    Run #10106

Run Properties:  status check passed Passed #10106  •  git commit 17a34ff02d ℹ️: Merge 4efb8e6d438205a749fd7ecc9ea511c761c184d9 into 06d25c744e7863bc3af0ed44c586...
Project fides
Branch Review refs/pull/5322/merge
Run status status check passed Passed #10106
Run duration 00m 39s
Commit git commit 17a34ff02d ℹ️: Merge 4efb8e6d438205a749fd7ecc9ea511c761c184d9 into 06d25c744e7863bc3af0ed44c586...
Committer Jason Gill
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gilluminate