fix: partially revert "Don't send the same parameters in query string and JWT for redirect URL (#360)" #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Stratus3D it would be great if you could test this PR against your Okta setup, as you were the original reporter. |
maennchen
approved these changes
Aug 31, 2024
|
@paulswartz yes I will test this now. |
|
I just tested my Elixir app with this: And it seems fine. I'm able to login and out no problem. Not sure why I determined all |
… and JWT for redirect URL (erlef#360)" This reverts partially commit 3b0b522. This commit started to fail the OIDC conformance suite: https://gitlab.com/paulswartz/ueberauth_oidcc_certification/-/pipelines/1391557144 In particular, the error is: Required http request parameters and request object claims must match ``` Required parameter 'response_type' was not found in http request parameters Required parameter 'client_id' was not found in http request parameters ``` `redirect_url` does not appear to be required, so we continue to leave that out.
maennchen
force-pushed
the
ps-request-object-params
branch
from
e8d2a18
to
c1170c3
Compare
maennchen
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts partially commit 3b0b522.
This commit started to fail the OIDC conformance suite: https://gitlab.com/paulswartz/ueberauth_oidcc_certification/-/pipelines/1391557144
In particular, the error is:
Required http request parameters and request object claims must match
redirect_urldoes not appear to be required, so we continue to leave that out.