Skip to content

Commit

Permalink
fix: partially revert "Don't send the same parameters in query string…
Browse files Browse the repository at this point in the history
… and JWT for redirect URL (#360)"

This reverts partially commit 3b0b522.

This commit started to fail the OIDC conformance suite:
https://gitlab.com/paulswartz/ueberauth_oidcc_certification/-/pipelines/1391557144

In particular, the error is:

Required http request parameters and request object claims must match

```
Required parameter 'response_type' was not found in http request parameters
Required parameter 'client_id' was not found in http request parameters
```

`redirect_url` does not appear to be required, so we continue to leave
that out.
  • Loading branch information
paulswartz committed Aug 30, 2024
1 parent 9ef9cc0 commit e8d2a18
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/oidcc_authorization.erl
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,8 @@ essential_params(QueryParams) ->
lists:filter(
fun
({<<"scope">>, _Value}) -> true;
({<<"response_type">>, _Value}) -> true;
({<<"client_id">>, _Value}) -> true;
(_Other) -> false
end,
QueryParams
Expand Down
2 changes: 2 additions & 0 deletions test/oidcc_authorization_SUITE.erl
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ create_redirect_url_inl_gov(_Config) ->

?assertMatch(
#{
<<"client_id">> := <<"client_id">>,
<<"response_type">> := <<"code">>,
<<"scope">> := <<"openid">>,
<<"request">> := _
},
Expand Down
2 changes: 2 additions & 0 deletions test/oidcc_authorization_test.erl
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,8 @@ create_redirect_url_with_request_object_test() ->

?assertMatch(
#{
<<"client_id">> := <<"client_id">>,
<<"response_type">> := <<"code">>,
<<"scope">> := <<"openid">>,
<<"should_be_in">> := <<"both">>,
<<"request">> := _
Expand Down

0 comments on commit e8d2a18

Please sign in to comment.