Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept Terms value to be any iterable #1887

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

roxanebellot
Copy link
Contributor

Fixes #1641

CLA is signed, PR is rebased !

Copy link
Collaborator

@miguelgrinberg miguelgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@miguelgrinberg miguelgrinberg added the backport 8.x Backport to 8.x label Aug 22, 2024
@miguelgrinberg miguelgrinberg merged commit 8cc2ed2 into elastic:main Aug 22, 2024
17 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 22, 2024
Co-authored-by: Roxane <r.bellot@octopusmind.info>
(cherry picked from commit 8cc2ed2)
miguelgrinberg pushed a commit that referenced this pull request Aug 22, 2024
Co-authored-by: Roxane <r.bellot@octopusmind.info>
(cherry picked from commit 8cc2ed2)

Co-authored-by: roxanebellot <roxane.bellot@gmail.com>
@pquentin
Copy link
Member

Thank you for your persistence Roxane!

@abrin
Copy link

abrin commented Sep 13, 2024

fyi -- the way this is implemented a term of "test" will turn into a query for ['t","e","s","t"]. not sure if this is intended, but it caught me by surprise

@pquentin
Copy link
Member

@abrin Good news! This was fixed in https://github.com/elastic/elasticsearch-dsl-py/releases/tag/v8.15.3, released one hour ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 8.x Backport to 8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for any iterable with "Terms" query
4 participants