Accept Terms value to be any iterable (#1887)

Co-authored-by: Roxane <r.bellot@octopusmind.info>
elastic · Aug 22, 2024 · 8cc2ed2 · 8cc2ed2
1 parent b762aae
commit 8cc2ed2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/elasticsearch_dsl/query.py b/elasticsearch_dsl/query.py
@@ -550,6 +550,9 @@ class Term(Query):
 class Terms(Query):
     name = "terms"
 
+    def _setattr(self, name: str, value: Any) -> None:
+        super()._setattr(name, list(value))
+
 
 class TermsSet(Query):
     name = "terms_set"

diff --git a/tests/test_query.py b/tests/test_query.py
@@ -77,6 +77,15 @@ def test_term_to_dict() -> None:
     assert {"term": {"_type": "article"}} == query.Term(_type="article").to_dict()
 
 
+def test_terms_to_dict() -> None:
+    assert {"terms": {"_type": ["article", "section"]}} == query.Terms(
+        _type=["article", "section"]
+    ).to_dict()
+    assert {"terms": {"_type": ["article", "section"]}} == query.Terms(
+        _type=("article", "section")
+    ).to_dict()
+
+
 def test_bool_to_dict() -> None:
     bool = query.Bool(must=[query.Match(f="value")], should=[])