Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for pep8 package (was used for --check-contrib + --check-style) #4634

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

Flamefire
Copy link
Contributor

It is outdated for many years now and has been replaced by pycodestyle. Stop using it.

@boegel
Copy link
Member

boegel commented Sep 17, 2024

@Flamefire Although very soon it won't matter anymore (because we'll collapse the 5.0.x branch into develop), this should target the 5.0.x currently...

@Flamefire Flamefire changed the base branch from develop to 5.0.x September 17, 2024 14:51
@Flamefire
Copy link
Contributor Author

Ok changed and extract #4644 for develop

It is outdated for many years now and has been replaced by pycodestyle.
Stop using it.
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartoldeman bartoldeman merged commit 7d93348 into easybuilders:5.0.x Sep 17, 2024
36 checks passed
@Flamefire Flamefire deleted the pep8 branch September 17, 2024 17:39
@Flamefire
Copy link
Contributor Author

Please also check #4644 to allow the EC PR

@boegel boegel added change EasyBuild-5.0 EasyBuild 5.0 labels Sep 18, 2024
@boegel boegel added this to the 5.0 milestone Sep 18, 2024
@boegel boegel changed the title Drop support for pep8 package Drop support for pep8 package (was used for --check-contrib + --check-style) Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants