Use pycodestyle in CI and fix style issues in EasyConfigs #21405
Conversation
framework uses pycodestyle if available and pep8 only as a fallback and later likely not at all (pep8 was renamed to pycodestyle and the existing package is no longer updated) So we need to check for either both or (more future proof) only for pycodestyle.
pep8 has bugs which makes it miss many issues like long-lines in docstrings. This might make the tests fail if both packages are available as framework prefers the newer pycodestyle.
These make the test fail, so fix them.
Flamefire
force-pushed
the
codestyle
branch
from
4e14c69
to
3e3727a
Compare
|
@Flamefire Seems like this needs a bit more love? You seem to be touching easyconfigs that will no longer be included with EasyBuild v5.0.0, no point in putting effort in those imho... |
Oh I thought it was only the ambiguous variable name issue. The problem with not fixing this is that we run the style check over all ECs and if we don't fix the style even in the old one the CI will continue to fail. Best we can do is ignore or fix the ambiguous variable names and merge the rest even though CI is failing with checksum issues etc. Otherwise we'd need to fix the other issues too which I think won't be to hard but boring ;-) |
…riable name reported by pycodestyle
|
Doing this cleanup in It's really only relevant for the |
|
Ok I see. However I did like the line breaks here more than the ones in #21502 resulting from the line wrapping. See https://github.com/easybuilders/easybuild-easyconfigs/pull/21502/files#r1782351340 |
framework uses pycodestyle if available and pep8 only as a fallback and later likely not at all (pep8 was renamed to pycodestyle and the existing package is no longer updated)
So we need to check for either both or (more future proof) only for pycodestyle.
Install it in CI to actually test it and fix the found issues to make the test pass again.
Requires:
--check-contrib+--check-style) easybuild-framework#4634