Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{bio}[GCCcore/10.3.0] subset-bam v1.1.0 #18032

Merged
merged 2 commits into from
Jun 6, 2023
Merged

{bio}[GCCcore/10.3.0] subset-bam v1.1.0 #18032

merged 2 commits into from
Jun 6, 2023

Conversation

sassy-crick
Copy link
Collaborator

(created using eb --new-pr)

@sassy-crick sassy-crick added the new label Jun 5, 2023
@casparvl
Copy link
Contributor

casparvl commented Jun 5, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=18032 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18032 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10917

Test results coming soon (I hope)...

- notification for comment with ID 1576647364 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@casparvl
Copy link
Contributor

casparvl commented Jun 5, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18032 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18032 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2705

Test results coming soon (I hope)...

- notification for comment with ID 1576654672 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen2g1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/a28cebd676fb7378fa48e274663e93d2 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/f0601ea8058bb1ff5c25c6e197f74da4 for a full test report.

@casparvl casparvl mentioned this pull request Jun 5, 2023
Open
casparvl
casparvl requested changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure on jsc-zen2 is due to a bug in the EasyBlock of Cargo. I reported it here easybuilders/easybuild-easyblocks#2946 . Imho, this EasyConfig doesn't need to wait for that, the bug is in the block.

The other failure, on generoso is a missing bzip2 dependency. That will need to be fixed.

@sassy-crick
Copy link
Collaborator Author

Failure on jsc-zen2 is due to a bug in the EasyBlock of Cargo. I reported it here easybuilders/easybuild-easyblocks#2946 . Imho, this EasyConfig doesn't need to wait for that, the bug is in the block.

The other failure, on generoso is a missing bzip2 dependency. That will need to be fixed.

Thanks for testing and thanks for finding the missing bzip2. I fixed that.

@casparvl
Copy link
Contributor

casparvl commented Jun 5, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=18032 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18032 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10920

Test results coming soon (I hope)...

- notification for comment with ID 1577009762 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@casparvl
Copy link
Contributor

casparvl commented Jun 5, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=18032 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18032 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10931

Test results coming soon (I hope)...

- notification for comment with ID 1577507110 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@casparvl
Copy link
Contributor

casparvl commented Jun 5, 2023

@boegelbot please test @ jsc-zen2
EB_ARGS="--include-easyblocks-from-pr 2947 --from-pr 18032"

@casparvl casparvl mentioned this pull request Jun 5, 2023
Merged
@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18032 EB_ARGS="--include-easyblocks-from-pr 2947 --from-pr 18032" /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18032 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2718

Test results coming soon (I hope)...

- notification for comment with ID 1577527592 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2947
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen2g1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/ca721a1baffc8adb31523353da0418ae for a full test report.

@Micket
Copy link
Contributor

Micket commented Jun 5, 2023

@boegelbot please test @ jsc-zen2
EB_ARGS="--include-easyblocks-from-pr 2947"

@Micket
Copy link
Contributor

Micket commented Jun 5, 2023

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-c1 - Linux Rocky Linux 8.7, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/24efaa5998faf4aea2ec34e7cf2130b5 for a full test report.

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18032 EB_ARGS="--include-easyblocks-from-pr 2947" /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18032 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2719

Test results coming soon (I hope)...

- notification for comment with ID 1577570087 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2947
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/7d0bd8b493db59378bda94627802e160 for a full test report.

@casparvl casparvl added this to the next release (4.7.3?) milestone Jun 6, 2023
casparvl
casparvl approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@casparvl
Copy link
Contributor

casparvl commented Jun 6, 2023

Going in, thanks @sassy-crick!

@casparvl casparvl merged commit 4e751f8 into easybuilders:develop Jun 6, 2023
@sassy-crick sassy-crick deleted the 20230605111220_new_pr_subset-bam110 branch June 6, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casparvl casparvl casparvl approved these changes

Assignees
No one assigned
Labels
new
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sassy-crick @casparvl @boegelbot @Micket