Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo EasyBlock doesn't support most non-empty optarch's #2946

Open
casparvl opened this issue Jun 5, 2023 · 4 comments
Open

Cargo EasyBlock doesn't support most non-empty optarch's #2946

casparvl opened this issue Jun 5, 2023 · 4 comments
Assignees

Comments

@casparvl
Copy link
Contributor

casparvl commented Jun 5, 2023

See this build failure.

Snippet from that log:

== 2023-06-05 12:03:05,327 build_log.py:171 ERROR EasyBuild crashed with an error (at easybuild/easybuild-framework/easybuild/base/exceptions.py:126 in __init__): cmd " cargo build --profile=release  --tests -j 8 -Z unstable-options " exited with exit code 101 and output:
error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `rustc - --crate-name ___ --print=file-names -C 'target-cpu={'\''Intel'\'':' ''\''march=core-avx2'\''}' --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=cfg` (exit code: 1)
  --- stderr
  error: multiple input filenames provided (first two filenames are `-` and `'march=core-avx2'}`)

I.e. it ends up with -C 'target-cpu={'\''Intel'\'':' ''\''march=core-avx2'\''}' and has no idea what to do with that.

I'm not sure, maybe something like self.toolchain.get_flag('optarch') should be done (which then returns march=core-avx2 for Intel based toolchains, and nothing for GCCcore I suppose) instead?

@Micket I hear you're the Cargo expert, care to have a look?

@Micket
Copy link
Contributor

Micket commented Jun 5, 2023

I.e. it ends up with -C 'target-cpu={'''Intel''':' ''''march=core-avx2'''}' and has no idea what to do with that.

The problem is that makes two of us. I have no idea what that optarch even means

@Micket
Copy link
Contributor

Micket commented Jun 5, 2023

Same as #2759

@casparvl
Copy link
Contributor Author

casparvl commented Jun 5, 2023

Possible fix proposed: #2947

@boegel boegel added this to the next release (4.7.3?) milestone Jun 7, 2023
@boegel
Copy link
Member

boegel commented Jun 20, 2023

Can this be closed now #2947 is merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants