Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: quoting of identifiers in diff, SQLite and test #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: quoting of identifiers in diff, SQLite and test #96

wants to merge 1 commit into from

Commits on Sep 22, 2017

  1. WIP: test quoting of identifiers in diff 

    In production, we found that the stable CPAN release of the PostgreSQL
producer did not quote identifiers in diffs.  We diagnosed the problem
and wrote a fix, only to see it was fixed in master.  Oh well, we
learned some more about SQLT!

I had adapted my test to run against a few producers, and found that
SQLite didn't work, even in master.  The first cause seemed like the
same bug as I found in PostgreSQL:  add_field did not pass its options
to the generator to inform its quoting.  I have fixed that in the patch,
but it still fails.

The fundamental problem appears to be the weird (to me) `$NO_QUOTES`
behavior.  That variable is set in `->produce`, a method that *does not
seem to be called* in the execution of the test program.  At that point,
I gave up for now, but I wanted to file this issue.
    @rjbs
    rjbs committed Sep 22, 2017
    Configuration menu
    Copy the full SHA
    e0b780c View commit details
    Browse the repository at this point in the history