WIP: quoting of identifiers in diff, SQLite and test #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In production, we found that the stable CPAN release of the PostgreSQL producer did not quote identifiers in diffs. We diagnosed the problem and wrote a fix, only to see it was fixed in master. Oh well, we learned some more about SQLT! I had adapted my test to run against a few producers, and found that SQLite didn't work, even in master. The first cause seemed like the same bug as I found in PostgreSQL: add_field did not pass its options to the generator to inform its quoting. I have fixed that in the patch, but it still fails. The fundamental problem appears to be the weird (to me) `$NO_QUOTES` behavior. That variable is set in `->produce`, a method that *does not seem to be called* in the execution of the test program. At that point, I gave up for now, but I wanted to file this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In production, we found that the stable CPAN release of the PostgreSQL
producer did not quote identifiers in diffs. We diagnosed the problem
and wrote a fix, only to see it was fixed in master. Oh well, we
learned some more about SQLT!
I had adapted my test to run against a few producers, and found that
SQLite didn't work, even in master. The first cause seemed like the
same bug as I found in PostgreSQL: add_field did not pass its options
to the generator to inform its quoting. I have fixed that in the patch,
but it still fails.
The fundamental problem appears to be the weird (to me)
$NO_QUOTESbehavior. That variable is set in
->produce, a method that does notseem to be called in the execution of the test program. At that point,
I gave up for now, but I wanted to file this issue.