Assets/icon: Rm redundant PNG file #33565
Open
+1
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selfdrive/assets/offroad/icon_openpilot.png
- This file gets deletedselfdrive/ui/qt/widgets/controls.cc
icon_pixmap = QPixmap(icon).scaledToWidth(80, Qt::SmoothTransformation);
selfdrive/assets/img_chffr_wheel.png
selfdrive/ui/qt/onroad/buttons.h
const int btn_size = 192;
const int img_size = (btn_size / 4) * 3;
I removed
icon_openpilot.png
because its 532x532 px size is unnecessary for a small 80x80 px icon displayed on a 2160x1080 screen.img_chffr_wheel.png
(266x266 px) is used for a larger 144x144 px icon but has a smaller file size. Quality of icon when using the smaller file size as the replacement, looks similar/the same to how the old icon rendered, as seen in video below.Comparing files
Comparison video
comparing-old-and-new-icon.mp4