-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix): Update recalculateBoundingBox in Cognite3DViewer #4715
Merged
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6a7e085
Update Cognite3DViewer.ts
nilscognite 38c69e0
Merge branch 'master' into np/cropping-fixes
nilscognite 4e133f9
Merge branch 'master' into np/cropping-fixes
nilscognite 38936c1
Merge branch 'master' into np/cropping-fixes
nilscognite 37892f3
Merge branch 'master' into np/cropping-fixes
nilscognite b83a9b7
Update Cognite3DViewer.ts
nilscognite 74981b1
Merge branch 'master' into np/cropping-fixes
nilscognite 4a7e17f
Merge branch 'master' into np/cropping-fixes
nilscognite 3901fed
Update Cognite3DViewer.ts
nilscognite 1e8d758
Update reveal.api.md
nilscognite 53be823
Refactoring
nilscognite 57c379a
Update Cognite3DViewer.ts
nilscognite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to have the
pass === 0
-check here as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't have that from before. It always used the visible object in these cases.