(fix): Update recalculateBoundingBox in Cognite3DViewer #4715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilscognite
changed the title
haakonflatval-cognite
approved these changes
Aug 21, 2024
| sceneBoundingBox.union(temporaryBox); | ||
| }); | ||
| this._sceneHandler.customObjects.forEach(customObject => { | ||
| if (!customObject.object.visible) { |
There was a problem hiding this comment.
Do we want to have the pass === 0-check here as well?
There was a problem hiding this comment.
It didn't have that from before. It always used the visible object in these cases.
nilscognite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description 📝
the function
fitCameraToModelsonly take all the models, even invisible and doesn't use thecustomobjectat all. In order not to break the code, I made an alternative which isfitCameraToSceneBoundingBox. This uses the getSceneBoundingBox.I also change the
recalculateBoundingBoxto use only visible object. See comment in that function. I believe that was the intension of the original code. It might break the code.... An alternative would be to make another function for doing this.I saw this bug during a demo today. The user had many models, but only one was visible. The navigation was pretty hard and the fit all button didn't work as expected.