Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include node cache in keep-alive context #3693

Merged
merged 5 commits into from
Sep 13, 2023
Merged

feat: include node cache in keep-alive context #3693

merged 5 commits into from
Sep 13, 2023

Conversation

haakonflatval-cognite
Copy link
Contributor

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/UX-1456

Description 📝

Make sure the FdmNodeCache is kept alive in the RevealKeepAlive context, alongside the Reveal viewer itself. This makes clicks responsive across the session, and it does not need to load the model asset mappings multiple times.

How has this been tested? 🔍

With FDX

Test instructions ℹ️

  • Build branch and connect to FDX through e.g. yalc
  • Start FDX
  • Open 3D view of model with mapped nodes
  • Keep the network tab open as you click on different mapped nodes
  • Notice that the first click on a node spawns multiple requests, subsequent ones spawn none (except for the graphql query from the node preview card).
  • Navigate away from the 3D view, e.g. by clicking Open on the preview card for a node
  • Then navigate back again, e.g. by clicking the 3D-view icon in the top right
  • Click some mapped nodes once again
  • The clicks do not spawn new requests, as they would without this change

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite added the slack PRs and issues with this label will be pushed to Slack label Sep 13, 2023
@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner September 13, 2023 08:10
Savokr
Savokr previously approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@Savokr Savokr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works nicely!

Savokr
Savokr approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@Savokr Savokr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Sep 13, 2023
@haakonflatval-cognite haakonflatval-cognite merged commit 5a8900e into master Sep 13, 2023
14 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/keep-node-cache-alive branch September 13, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greenbech greenbech greenbech left review comments

@Savokr Savokr Savokr approved these changes

Assignees
No one assigned
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haakonflatval-cognite @greenbech @Savokr