fix: add useMemo dependencies and explaratory variable

cognitedata · Sep 13, 2023 · cf2be26 · cf2be26
1 parent fe3ce1d
commit cf2be26
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/react-components/src/components/NodeCacheProvider/NodeCacheProvider.tsx b/react-components/src/components/NodeCacheProvider/NodeCacheProvider.tsx
@@ -103,11 +103,14 @@ export function NodeCacheProvider({ children }: { children?: ReactNode }): React
   const fdmCache = useMemo(() => {
     const cache =
       revealKeepAliveData?.fdmNodeCache.current ?? new FdmNodeCache(cdfClient, fdmClient);
-    if (revealKeepAliveData !== undefined) {
+
+    const isInRevealKeepAliveContext = revealKeepAliveData !== undefined;
+    if (isInRevealKeepAliveContext) {
       revealKeepAliveData.fdmNodeCache.current = cache;
     }
+
     return cache;
-  }, []);
+  }, [cdfClient, fdmClient]);
 
   return (
     <FdmNodeCacheContext.Provider value={{ cache: fdmCache }}>