Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply clipping planes on newly loaded point clouds #3433

Merged
merged 1 commit into from
Jun 27, 2023

fix: apply clipping planes on newly loaded point clouds

6d01c1e
Select commit
Loading
Failed to load commit list.
Merged

fix: apply clipping planes on newly loaded point clouds #3433

fix: apply clipping planes on newly loaded point clouds
6d01c1e
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Jun 27, 2023 in 0s

71.52% (-0.01%) compared to e0a533e

View this Pull Request on Codecov

71.52% (-0.01%) compared to e0a533e

Details

Codecov Report

Merging #3433 (6d01c1e) into master (e0a533e) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #3433      +/-   ##
==========================================
- Coverage   71.53%   71.52%   -0.01%     
==========================================
  Files         344      344              
  Lines       33235    33241       +6     
  Branches     2582     2581       -1     
==========================================
+ Hits        23773    23776       +3     
- Misses       9358     9361       +3     
  Partials      104      104              
Impacted Files Coverage Δ
...ewer/packages/pointclouds/src/PointCloudManager.ts 68.02% <33.33%> (-0.73%) ⬇️
...ackages/rendering/src/PointCloudMaterialManager.ts 76.54% <50.00%> (+0.29%) ⬆️