Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply clipping planes on newly loaded point clouds #3433

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

haakonflatval-cognite
Copy link
Contributor

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/REV-969

Description 📝

Make sure global clipping planes are applied to point cloud models upon load. Before, it would be necessary to e.g. adjust the clipping planes again after load, as to make it effective on the point cloud.

CAD models don't have this issue.

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite added the slack PRs and issues with this label will be pushed to Slack label Jun 27, 2023
@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner June 27, 2023 12:09
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #3433 (6d01c1e) into master (e0a533e) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #3433      +/-   ##
==========================================
- Coverage   71.53%   71.52%   -0.01%     
==========================================
  Files         344      344              
  Lines       33235    33241       +6     
  Branches     2582     2581       -1     
==========================================
+ Hits        23773    23776       +3     
- Misses       9358     9361       +3     
  Partials      104      104              
Impacted Files Coverage Δ
...ewer/packages/pointclouds/src/PointCloudManager.ts 68.02% <33.33%> (-0.73%) ⬇️
...ackages/rendering/src/PointCloudMaterialManager.ts 76.54% <50.00%> (+0.29%) ⬆️

Copy link
Contributor

@Savokr Savokr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@haakonflatval-cognite haakonflatval-cognite merged commit d197669 into master Jun 27, 2023
19 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/clip-models-on-load branch June 27, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants