-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: modernize build configs #271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsstevenson
changed the title
build: configure setuptools in pyproject.toml
build: modernize build configs
Oct 2, 2023
@jsstevenson what's the priority? |
@korikuzma new rule if we (I) forget to mark a priority then we (you) consider it to be very low |
korikuzma
reviewed
Oct 3, 2023
authors = [ | ||
{name = "Alex Wagner"}, | ||
{name = "Kori Kuzma"}, | ||
{name = "James Stevenson"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THE James
korikuzma
previously approved these changes
Oct 3, 2023
jsstevenson
added a commit
that referenced
this pull request
Oct 3, 2023
* Use the "src" layout instead of a "flat" layout. It is argued that this is better: https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/ * Move build settings into `pyproject.toml`. People seem to think this is more "modern". At the very least, it means fewer files for us to manage. Removed some deprecated settings while in here. * Add a few additional PyPI classifiers. * Update default test command options (they were showing their age)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyproject.toml
. People seem to think this is more "modern". At the very least, it means fewer files for us to manage. Removed some deprecated settings while in here.