BCR PR reviewer: add support for a "do_not_notify" field #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A maintainer can request to not be notified by new PRs by setting `"doNotNotify": true`. In this case, they can still approve the PR and have it count, but they won't be pinged. This helps in situations like protobuf's release rotation, which has a lot of people but ideally only the releaser should be notified and be able to approve the PR. It's rather hard to support a "rotating" maintainer model, though. Thus we compromise by adding everyone from that rotation as a "do-not-notify" maintainer, and asking the releaser to watch out for the PR manually as a release step.
metadata.json already has the field "yanked_versions" using lower snake case, so I updated this field to follow suit.
Wyverald
changed the title
Wyverald
added a commit
to bazelbuild/bazel-central-registry
that referenced
this pull request
Sep 18, 2024
See bazelbuild/continuous-integration#2037. This PR updates the workflows to include that change, and the schema of metadata.json to add the new "do_not_notify" field.
Wyverald
added a commit
to bazelbuild/bazel-central-registry
that referenced
this pull request
Sep 18, 2024
See bazelbuild/continuous-integration#2037. This PR updates the workflows to include that change, and the schema of metadata.json to add the new "do_not_notify" field. cc @zhangskz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A maintainer can request to not be notified by new PRs by setting
"do_not_notify": true. In this case, they can still approve the PR and have it count, but they won't be pinged.This helps in situations like protobuf's release rotation, which has a lot of people but ideally only the releaser should be notified and be able to approve the PR. It's rather hard to support a "rotating" maintainer model, though. Thus we compromise by adding everyone from that rotation as a "do-not-notify" maintainer, and asking the releaser to watch out for the PR manually as a release step.
cc @zhangskz