Skip to content

Commit

Permalink
BCR PR reviewer: Add support for a "do_not_notify" field (#2806)
Browse files Browse the repository at this point in the history
See bazelbuild/continuous-integration#2037. This
PR updates the workflows to include that change, and the schema of
metadata.json to add the new "do_not_notify" field.

cc @zhangskz
  • Loading branch information
Wyverald committed Sep 18, 2024
1 parent 11a2c4e commit 9f10e64
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/dismiss_approvals.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
egress-policy: audit

- name: Run BCR PR Reviewer
uses: bazelbuild/continuous-integration/actions/bcr-pr-reviewer@ecb81a9f161e6a560633222436406e41b93f6991 # master
uses: bazelbuild/continuous-integration/actions/bcr-pr-reviewer@2997e589af56c74eeccaf79640f20a6b40e1b0b6 # master
with:
# This token needs to be updated annually on Feb 05.
token: ${{ secrets.BCR_PR_REVIEW_HELPER_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/notify_maintainers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
egress-policy: audit

- name: Run BCR PR Reviewer
uses: bazelbuild/continuous-integration/actions/bcr-pr-reviewer@ecb81a9f161e6a560633222436406e41b93f6991 # master
uses: bazelbuild/continuous-integration/actions/bcr-pr-reviewer@2997e589af56c74eeccaf79640f20a6b40e1b0b6 # master
with:
# This token needs to be updated annually on Feb 05.
token: ${{ secrets.BCR_PR_REVIEW_HELPER_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/review_prs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

- name: Run BCR PR Reviewer
if: github.repository_owner == 'bazelbuild'
uses: bazelbuild/continuous-integration/actions/bcr-pr-reviewer@ecb81a9f161e6a560633222436406e41b93f6991 # master
uses: bazelbuild/continuous-integration/actions/bcr-pr-reviewer@2997e589af56c74eeccaf79640f20a6b40e1b0b6 # master
with:
# This token needs to be updated annually on Feb 05.
token: ${{ secrets.BCR_PR_REVIEW_HELPER_TOKEN }}
Expand Down
4 changes: 4 additions & 0 deletions metadata.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@
"name": {
"type": "string",
"description": "maintainer's name"
},
"do_not_notify": {
"type": "boolean",
"description": "when set to true, this maintainer won't be notified by new PRs, but still has approver rights"
}
}
}
Expand Down

0 comments on commit 9f10e64

Please sign in to comment.