Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Trailing slash with argument is not respected #140

Merged
merged 3 commits into from
Dec 29, 2023
Merged

bug: Trailing slash with argument is not respected #140

merged 3 commits into from
Dec 29, 2023

Commits on Dec 19, 2023

  1. Fix linting errors 

    Avoid unused loops, trailing whitespaces and hiding global vars.
    @boekkooi-lengoo
    boekkooi-lengoo committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    afcc1ac View commit details
    Browse the repository at this point in the history

  2. Trailing Slash not respected with parameter 

    Show the issue where when an argument is specified it's also matching without the trailing slash
    @boekkooi-lengoo
    boekkooi-lengoo committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    6265c1b View commit details
    Browse the repository at this point in the history

  3. Handle the trailing slash 

    As ngx.re.split will `delete empty trailing ones` we need to double check that there is no required `/` at the end of the path.
If there is a extra `/` then add it to the pat regex.

Also see https://github.com/openresty/lua-resty-core/blob/50f73790b6bb1d83f52cb3b4ec7e4ab7f649ab32/lib/ngx/re.lua#L273
    @boekkooi-lengoo
    boekkooi-lengoo committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    5774e96 View commit details
    Browse the repository at this point in the history