bug: Trailing slash with argument is not respected #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid unused loops, trailing whitespaces and hiding global vars.
Show the issue where when an argument is specified it's also matching without the trailing slash
As ngx.re.split will `delete empty trailing ones` we need to double check that there is no required `/` at the end of the path. If there is a extra `/` then add it to the pat regex. Also see https://github.com/openresty/lua-resty-core/blob/50f73790b6bb1d83f52cb3b4ec7e4ab7f649ab32/lib/ngx/re.lua#L273
boekkooi-lengoo
changed the title
|
Thanks for your contribution! we will check it later |
|
@monkeyDluffy6017 welcome to take a look at this PR, thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day.
Thanks for having a look at this PR that is trying to fix an issue where the trailing slash of a path is not respected when a argument is set before it.
Cheers,
Warnar