Remove callback group for topics and services #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this with apps that have several C++ components, by either shutting down the state engine directly or unloading components one by one through the API and this seems to work fine. The state engine doesn't crash anymore (at least not more often than before) |
eeberhard
approved these changes
Oct 24, 2023
|
P.S. can you link / close the related issue if it still exists somewhere? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR finally solves the problem with unloading components after the component interface refactor. It's been some time since we last worked on this but I rebased the 'iron' branch (the branch that has the 4 commits regarding the component interface refactor with node interfaces) and found that the issue with that was just an additional callback group that I created for I don't know what reason and that group was responsible for the issues when removing the component from the executor.
Review guidelines
Estimated Time of Review: 5 minutes
Checklist before merging: