Refactor component predicates #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
As discussed, let's tag a release 2.3.0 first before merging this |
* Add definition for Predicate message * Refactor PredicateListener to have only one subscription * Have only one publisher that publishes Predicate message on global topic * Remove generate_predicate_topic helper * Small updates in tests * Update CHANGELOG * modulo_utils depends on interfaces now * 2.2.7 -> 2.2.8
domire8
force-pushed
the
refactor/predicates
branch
from
f963acb
to
6056311
Compare
eeberhard
approved these changes
Jul 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the issue by adding the 3 commits from the iron branch to develop. This has been tested reasonably well and should be included in the last supported version of modulo on humble
Review guidelines
Estimated Time of Review: 1.1 minutes