Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for generic subscriptions #144

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

bpapaspyros
Copy link
Member

@bpapaspyros bpapaspyros commented Sep 29, 2024

Description

Along with the changes in #141 and #143, this PR aims to introduce generic subscriptions.

Pending:

  • add a couple more tests for callbacks in subscriptions
  • n/a TODO

This PR solves the issue by propagating the new concept-related compile-time conditions to add_input, and restructuring the MessagePair::read_message to perform compile-time inference about the functions that need to be used for the given MsgT.

Review guidelines

Estimated Time of Review: 15 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

Related issues

Blocked by:

Blocks:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant