forked from epfl-lasa/modulo
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: version 5.0.0-rc0001 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to CL v8.1.0 (#106) * feat: remove utilities header from modulo controllers * feat: throw exception on get parameter * feat: use cl 8.1.0
* refactor: change predicate topic of controllers * docs: changelog
* feat(components): only publish predicate on change (cpp) * feat(components): only publish predicate on change (py) * feat: add unittests for predicate class * fix: triggers
I've also built and run a full jazzy backend with this version now and seems to work fine so far |
🚂 🔥This is a great moment! Lots of hard work behind the scenes. Let's go for it with the breaking changes on main, with the pre-release tag there to make sure we can patch anything before fully committing to 5.0. I assume the merge strategy will be to fast-forward the commits to main. |
eeberhard
approved these changes
Jul 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks to #126, if I forward this onto main, it should build and release modulo as
v5.0.0-rc0001
androlling
such that we can continue with the refactors throughout the stack.Review guidelines
Estimated Time of Review: 2 minutes
Checklist before merging: