Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(controllers): only publish predicates on value change #124

Merged
merged 2 commits into from
Jul 4, 2024
Merged

feat(controllers): only publish predicates on value change #124

merged 2 commits into from
Jul 4, 2024

Conversation

domire8
Copy link
Member

@domire8 domire8 commented Jul 4, 2024 •
edited
Loading

Description

Same as #123 but for the controller interface

Review guidelines

Estimated Time of Review: 10 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@domire8 domire8 requested a review from eeberhard July 4, 2024 15:18
eeberhard
eeberhard approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! still some code duplication between components and controllers of course but at least re-using the new Predicate class already makes things quite nice.

@domire8 domire8 merged commit b83d550 into breaking Jul 4, 2024
4 checks passed
@domire8 domire8 deleted the feat/controller-predicates branch July 4, 2024 15:43
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eeberhard eeberhard eeberhard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domire8 @eeberhard