Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: try catch lifecycle transitions in components and controllers #120

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

domire8
Copy link
Member

@domire8 domire8 commented Jun 24, 2024

Description

A small quality of life improvement that I suggest.

Review guidelines

Estimated Time of Review: 5 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

Copy link
Member

@bpapaspyros bpapaspyros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a very sensible choice to catch things at the highest level, I have nothing against this. Thanks for the suggestion and implementation!

@domire8 domire8 force-pushed the feat/try-catch-transitions branch from 0c25679 to 70621f3 Compare July 3, 2024 07:55
Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems nice, good change. If a user still wants to raise an error during a transition, we can and should enable that through the raise_error function to trigger a state change (which is still a TODO I know)

@domire8 domire8 merged commit 6bfc04f into breaking Jul 3, 2024
4 checks passed
@domire8 domire8 deleted the feat/try-catch-transitions branch July 3, 2024 13:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants