feat(modulo-controllers): use exceptions from modulo utils and update to CL v8.1.0 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpapaspyros
approved these changes
May 30, 2024
source/modulo_controllers/include/modulo_controllers/ControllerInterface.hpp
Show resolved
Hide resolved
domire8
commented
May 31, 2024
source/modulo_controllers/include/modulo_controllers/ControllerInterface.hpp
Show resolved
Hide resolved
eeberhard
approved these changes
Jun 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR for our staging branch. To be consistent with
modulo_components, the controller interface should also throw exceptions in the same places (get_parameter/_value) in this case. For that, we can use the exceptions frommodulo_utils. This allows to delete theutitilies.hppheader within modulo controllers.Review guidelines
Estimated Time of Review: 5 minutes
Checklist before merging: