Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Json decoding #317

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Fix Json decoding #317

merged 3 commits into from
Feb 6, 2024

Conversation

HannaTarasevich
Copy link
Contributor

Fix #316

@WasiqB
Copy link
Owner

WasiqB commented Feb 3, 2024

Hi @HannaTarasevich , thanks for contributing to the project.

Please fix the failing test.

@HannaTarasevich
Copy link
Contributor Author

Hi @WasiqB ,
Fixed

@WasiqB WasiqB merged commit 22e9663 into WasiqB:main Feb 6, 2024
1 check passed
@HannaTarasevich
Copy link
Contributor Author

HannaTarasevich commented Feb 6, 2024

Thanks @WasiqB!
Could we please release this update?

@WasiqB
Copy link
Owner

WasiqB commented Feb 6, 2024

Sure @HannaTarasevich , once I reach home I will release this change

@ymouhat
Copy link

ymouhat commented Apr 4, 2024

Hi @WasiqB
after updating to version 3.6.2 I got the following result in show-info

image

@cucumber/cucumber": "^10.0.0"
multiple-cucumber-html-reporter": "^3.6.2"
nodejs: 20.12.0
pnpm: 8.15.6
Platform : ubuntu

is this fix is supposed to fix that problem too?
THank you in advance.

@HannaTarasevich
Copy link
Contributor Author

Hi @ymouhat,
The fix is about JSON-attachment only.

By the way, @cucumber/cucumber v10 use string literals to attach all the data to json-report now (cucumber/cucumber-js#2260), previously it was encoded. Your data is displayed as encoded, so I'd recommend to debug locally if your JSON-files with reports still contain encoded data.

@ymouhat
Copy link

ymouhat commented Apr 4, 2024

HI @HannaTarasevich Thank you for your reply.

@pls-spyro
Copy link

Hi, I have the same issue as @ymouhat - I have to stick to the 3.6.0 version in my reports because of that...

@ymouhat
Copy link

ymouhat commented Apr 29, 2024

Hi @pls-spyro
if it can help.
for now we stayed in version 3.5.0 where the issue doesn't occur.
The developer indicated the problem seems to be due to the 3-party component "wdio-cucumberjs-json-reporter" .
we are currently migrating to wdio8 that should give us the possibility to upgrade wdio-cucumberjs-json-reporter and then multiple-cucumber-html-reporter to 3.6.2

@v-mwalk
Copy link

v-mwalk commented May 30, 2024

Just FYI - I hit this issue big time after moving to CucumberJS 10.8.0.

The test framework we use is Playwright/Cucumber based with multiple-cucumber-html-reporter being used to make results look pretty and usable. However, as happened to Hanna, it meant all the text logging showed as base64 uck and screenshots/video (video was being attached as text/html within hand-rolled

However, updating to 3.6.2 mchr fixes all this nicely - thanks Hanna/Wasiq. But note, only take 3.6.2 IF using attachments and moving to Cucumber v10+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON attachments are not displayed correctly after upgrade to 3.6.1 (Cucumber 10+) due to broken decoding
5 participants