Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML report from the JSON output is not able to Base64 decode the attachment body #293

Closed
joao-motork opened this issue Nov 9, 2023 · 2 comments

Comments

@joao-motork
Copy link

Environment (please complete the following information):

  • multiple-cucumber-html-reporter: [3.5.0]
  • Node.js version: [20.7.0]
  • NPM version: [10.1.0]
  • Platform name and version: [Windows 10]
  • Cucumber version: [10.0.1]

Describe the bug
With the launch of cucumber-js 10 all attachments are Base64 encoded regardless of how they were initially attached:

image

So, generating an HTML report with the multiple-cucumber-html-reporter we will have this:
image

Expected behavior
The code that produces your HTML report from the JSON output will need to be able to Base64 decode the attachment body.

Additional notes
https://github.com/cucumber/cucumber-js/blob/main/UPGRADING.md#attachments-in-json-formatter
cucumber/cucumber-js#2350

@WasiqB
Copy link
Owner

WasiqB commented Feb 6, 2024

Hey @joao-motork , please check with latest release v3.6.2 and revert if the issue is now fixed. We have released a patch for JSON decoding in PR #317 .

@joao-motork
Copy link
Author

Hi @WasiqB
With release v3.6.2, it is fixed.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants