Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add arabic translation #141

Merged
merged 3 commits into from
Jun 29, 2023
Merged

add arabic translation #141

merged 3 commits into from
Jun 29, 2023

Conversation

nakibrayan3
Copy link
Contributor

@nakibrayan3 nakibrayan3 commented Jun 29, 2023

Licensing

  • I confirm that this is either my code or was released under the terms of a GPLv3-or-later compatible license. Also I agree to release it here under the terms of the GPLv3-or-later.

Description

i added Arabic translation to Tubefeeder.

and i don't know how to test the translation, i tried compiling but the app runs on English (my language for gnome is set to Arabic, and every other app runs on Arabic by default) , please tell me if there is a way for me to test the translation before merging the pull request.

Linked Issue

i made this PR without creating an issue

@Schmiddiii
Copy link
Collaborator

Looks good to me.

and i don't know how to test the translation

Did you compile the Flatpak or with meson? With meson, i18n does not work.

You should also be able to download the Flatpak that is created by the CI pipeline and test it there.

@Schmiddiii Schmiddiii merged commit 11af1c1 into Tubefeeder:master Jun 29, 2023
1 check passed
@nakibrayan3 nakibrayan3 deleted the arabic-translation branch June 30, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants