Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set includeOriginalStrings to false #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

set includeOriginalStrings to false #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions download_file_request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ func (request FileDownloadRequest) GetQuery() url.Values {

if request.IncludeOriginal {
query.Set("includeOriginalStrings", "true")
}else{
query.Set("includeOriginalStrings", "false")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that we should explicit tell false. My expectation - if the parameter is not provided then its value false.
I want to talk with someone in File API team to confirm my assumption.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some test with curl (with includeOriginalStrings not set) and it seems to me (maybe it is somewhere hidden in my project settings that I missed) that the default value is true here. but getting clarification from the team is definitely a good idea, maybe they can update the official doc for that too, thanks!

}

return query
Expand Down