set includeOriginalStrings to false #3
Conversation
includeOriginalStrings by default will be set to true so it will never be set to false unless we set it explicitly here to false
| @@ -55,6 +55,8 @@ func (request FileDownloadRequest) GetQuery() url.Values { | |||
|
|
|||
| if request.IncludeOriginal { | |||
| query.Set("includeOriginalStrings", "true") | |||
| }else{ | |||
| query.Set("includeOriginalStrings", "false") | |||
There was a problem hiding this comment.
I'm not sure that we should explicit tell false. My expectation - if the parameter is not provided then its value false.
I want to talk with someone in File API team to confirm my assumption.
There was a problem hiding this comment.
I did some test with curl (with includeOriginalStrings not set) and it seems to me (maybe it is somewhere hidden in my project settings that I missed) that the default value is true here. but getting clarification from the team is definitely a good idea, maybe they can update the official doc for that too, thanks!
|
any updates on this? 🙇 |
|
i ran into this issue as well when rewriting python code, current implementation is definitely broken |
|
Still an issue. The server default appears to be includeOriginalStrings=true , which agreed is counterintuitive but appears to be the way things are. With this fix applied the tool worked as I needed. I don't think the command line client allows setting this parameter yet, either, but if that is added perhaps support parameter values of true/false/default, in case the server behavior changes, and send the parameter in case of the first two. |
|
lol, cmon, lets get some injectable behavior here lol. This PR creates some configuration. |
|
Yeah, it'd probably be best to allow "ServerDefault", "true", and "false" settings, so if the user supplied a command-line flag, it would always send true/false rather than having the client library assume what the server's behavior is, with "ServerDefault" not adding the parameter. But, the current server behavior is "true", so there absolutely has to be a way to pass false. |
includeOriginalStrings by default will be set to true in the rest api def (although the doc didn't mention the default value)
so it will never be set to false unless we set it explicitly here to false