Fixes the release with goreleaser fixed version #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Replacements](https://github.com/Skyscanner/turbolift/blob/9f28424daf82663b91716b6888c12cfb6a04ca0e/.goreleaser.yml#L16-L21) have been deprecated on goreleaser since this [commit](https://github.com/goreleaser/goreleaser/pull/3589/files#diff-5563ff2aab3eb7eae7bd8557cd2c086d8373263762684283485b2f0a00a0f52a). The github action for goreleaser unfortunately uses the latest goreleaser version instead of a fixed version. We need to address the replacements in a future commit, for now we are just forcing an older version of goreleaser. The version of goreleaser that includes the deprecation of `replacements` is [v1.19.0](https://github.com/goreleaser/goreleaser/releases/tag/v1.19.0). We are rolling back now to [v1.18.2](https://github.com/goreleaser/goreleaser/releases/tag/v1.18.2).
rnorth
approved these changes
Nov 9, 2023
sledigabel
added a commit
that referenced
this pull request
Nov 9, 2023
Since v1.19.0, goreleaser is not supporting replacements in its configuration, rather it points you to using a template. This change reverses the workaround from #110 and introduces a forward-fix for this. We still have an issue with goreleaser action using `latest` but it's by design on their behalf.
sledigabel
added a commit
that referenced
this pull request
Feb 12, 2024
* Fix goreleaser and deprecate replacements Since v1.19.0, goreleaser is not supporting replacements in its configuration, rather it points you to using a template. This change reverses the workaround from #110 and introduces a forward-fix for this. We still have an issue with goreleaser action using `latest` but it's by design on their behalf. * taps are deprecrated, changing too * fix(goreleaser): Adding version to template After further reading on the documentation, we were missing the Version on the package names. FYI, the command to test the full build, renaming and skip publish is: ``` goreleaser --snapshot --skip-publish --rm-dist ``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
Goreleaser has deprecated Replacements since this commit.
The github action for goreleaser uses the latest goreleaser version instead of a fixed version.
We need to address the replacements in a future commit, for now we are forcing an older version of goreleaser.
The version of goreleaser that includes the deprecation of
replacementsis v1.19.0.We are rolling back now to v1.18.2.