Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use the latest version of goreleaser #111

Closed
sledigabel opened this issue Oct 13, 2023 · 3 comments
Closed

Cannot use the latest version of goreleaser #111

sledigabel opened this issue Oct 13, 2023 · 3 comments

Comments

@sledigabel
Copy link
Contributor

Goreleaser deprecated the use of replacements in this PR: https://github.com/goreleaser/goreleaser/pull/3589/files#

We do use replacements at the moment, and this is breaking the 2.3.0 release.

We have filed #110 to address the problem short term and force github actions to use an old version of goreleaser.

In the future we need to remove the replacements statement and understand how this affects how build publishing.

@sledigabel
Copy link
Contributor Author

Looking further into it, this could be a way forward if the results truly are the same:
https://goreleaser.com/deprecations/#archivesreplacements

I would also look at whether those replacements are actually needed in the first place.
The impact seems to be here with the namings: https://github.com/Skyscanner/homebrew-tools/blob/main/turbolift.rb

TBH if the proposed solution to replace archives replacement with the bit of go template works as expected I wouldn't necessarily look further.

@sledigabel
Copy link
Contributor Author

Opened #115 to rectify this too.

@sledigabel
Copy link
Contributor Author

fixed by #115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant