[not for merge] tidying threads and file descriptors at shutdown #3397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benclifford
force-pushed
the
benc-stdstreams-bugs
branch
4 times, most recently
from
ef0f2bf
to
ea3f8f7
Compare
benclifford
force-pushed
the
benc-stdstreams-bugs
branch
from
ea3f8f7
to
af8da67
Compare
benclifford
added a commit
that referenced
this pull request
Jul 2, 2024
This stops that thread being left still running over the end of the test - which is needed in work in PR #3397 to ensure that no threads are left running at the end of a test. If that shutdown hangs, this test will now hang rather than leave the thread behind. Along with PR #3504, this eliminates any threads left behind after parsl/tests/test_providers/test_local_provider.py
benclifford
added a commit
that referenced
this pull request
Jul 3, 2024
This stops that thread being left still running over the end of the test - which is needed in work in PR #3397 to ensure that no threads are left running at the end of a test. If that shutdown hangs, this test will now hang rather than leave the thread behind. Along with PR #3504, this eliminates any threads left behind after parsl/tests/test_providers/test_local_provider.py
benclifford
force-pushed
the
benc-stdstreams-bugs
branch
from
af8da67
to
979b009
Compare
benclifford
force-pushed
the
benc-stdstreams-bugs
branch
from
979b009
to
7339d0a
Compare
benclifford
added a commit
that referenced
this pull request
Aug 8, 2024
This releases 2 file descriptors with work queue (from 21 to 19 at the end of CI Work Queue test) and 4 file descriptors with Task Vine (from 19 to 15 at the end of CI Task Vine test) This is part of work being merged from draft PR #3397 to shut down components more cleanly, rather than relying on process exit.
benclifford
added a commit
that referenced
this pull request
Aug 8, 2024
This releases 2 file descriptors with work queue (from 21 to 19 at the end of CI Work Queue test) and 4 file descriptors with Task Vine (from 19 to 15 at the end of CI Task Vine test) This is part of work being merged from draft PR #3397 to shut down components more cleanly, rather than relying on process exit.
benclifford
force-pushed
the
benc-stdstreams-bugs
branch
2 times, most recently
from
e2b0448
to
96f1e63
Compare
Before this PR, this thread stays running forever, until it is terminated by Python process exit. After this PR, this thread polls an flag once per second, then properly closes the ZMQ socket that it is using. pytest parsl/tests/test_monitoring/ --config local Before this PR, at end of test: 32 threads, 451 fds open. After this PR, at end of test: 1 thread, 48 fds open.
.. and use that new parameter in stderr/out tests which don't make use of the UDP radio.
benclifford
force-pushed
the
benc-stdstreams-bugs
branch
from
96f1e63
to
a4e0c61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a patch stack in my dev environment where i have been pushing on cleanup of threads and file descriptors at shutdown, with the eventual goal of having pytest fixtures assert that only the main thread is running and the same number of file descriptors are open at the start and the end. I've been merging work from this already in small pieces and will continue to merge small tidyups from it.
There is at least one large part which needs some thought and discussion, which is how to shut down the htex queue processing thread - the engine of almost everything in htex that doesn't happen immediately on user task submission.