Close stdin used to send config to Interchange #3501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced in PR #3463 and at the time I incorrectly assumed that interchange exit would close both ends of the pipe. That is untrue. For example: pytest parsl/tests/test_htex/ --config local ends with 341 fds open before this PR, and 327 file descriptors open after this PR.
khk-globus
approved these changes
Jul 1, 2024
Comment on lines
553
to
555
| stdin.flush() | ||
| stdin.close() | ||
| logger.debug("Sent config object. Requesting worker ports") |
There was a problem hiding this comment.
Suggest adding some version of a UT for this. It's not an important detail, per se, but it's also a detail that I can see being easily forgotten/missed in a refactor. Especially from newer contributors.
There was a problem hiding this comment.
#3397 is a longer term plan to catch all leftover fds and threads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in PR #3463 and at the time I incorrectly assumed that interchange exit would close both ends of the pipe. That is untrue.
For example: pytest parsl/tests/test_htex/ --config local ends with 341 fds open before this PR,
and 327 file descriptors open after this PR.
Changed Behaviour
nothing should be user visible, but less file descriptor usage
Type of change