Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sol_interface! when expanding empty args #48

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Fix sol_interface! when expanding empty args #48

merged 3 commits into from
Sep 1, 2023

Conversation

rachel-bousfield
Copy link
Contributor

Fixes sol_interface! when given expanding args.
We'd mistakenly expanded it to (,), rather than ().

sol_interface! {
    interface IClass {
        function empty();
    }
}

Solves: #44

@cla-bot cla-bot bot added the s label Sep 1, 2023
joshuacolvin0
joshuacolvin0 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rachel-bousfield rachel-bousfield merged commit 3e8693c into stylus Sep 1, 2023
9 checks passed
@rachel-bousfield rachel-bousfield deleted the fix-sol-interface branch September 1, 2023 23:09
@rachel-bousfield rachel-bousfield mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisco512 chrisco512 chrisco512 approved these changes

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

Assignees
No one assigned
Labels
s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rachel-bousfield @chrisco512 @joshuacolvin0