Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sol_interface! macro with no arguments #44

Closed
wants to merge 1 commit into from

Conversation

evmcheb
Copy link

@evmcheb evmcheb commented Sep 1, 2023

I think sol_interface! is broken if you pass in no arguments due to a leading comma

sol_interface! {
    interface A {
        function B() view returns (address);
    }
}
error: expected type, found `,`
  --> src/main.rs:22:1
   |
22 | / sol_interface! {
23 | |     interface A {
24 | |         function B() view returns (address);
25 | |     }
26 | | }
   | |_^ expected type
   |

This change to the macro should fix it (untested, I couldn't get a testing environment to work)

@cla-bot
Copy link

cla-bot bot commented Sep 1, 2023

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@evmcheb evmcheb changed the title fix: fix: sol_interface! macro with no arguments Sep 1, 2023
@hkalodner
Copy link

Hey @evmcheb, thanks for the contribution! Just bumping are you ok with signing the contributor agreement? Would love to get a fix for this issue merged in 🙏

@rachel-bousfield
Copy link
Contributor

Thanks for the PR! We went ahead and solved this along with another fix in the following PR that'll be included in the v0.2.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants