New ASPH H update algorithm #302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scale udpate rules. Also a few minor fixes for generating ratio spheres in 2D.
for looking up nperh information for ideal H estimation. Preparing for adding new interpolators based on the second moment for our new ASPH approach.
do with the changes in this branch).
applying limits to the allowed nperh lookup range to ensure there's something to sample from. Brody's TestIntegrator function is failing now for reasons I don't understand, so leaving that alone 'til I figure out why.
convergence checking.
consistent with QuadraticInterpolator
zeroth, first, and 2 second moments be passed in. Also updated all the hydros that call these methods to compute those moments (untested still).
functionality into the ordinary ASPH algorithm object now.
our current second moment does not reliably work
shape tensor using convex hulls.
…not provided. Also made tests more robust.
…nditions should be applied
|
@jmikeowen when I built this branch with SpheralC tests, the Taylor impact tests will croak in the call to spheral_initialize_boundaries_and_physics() (or initializeBoundariesAndPhysics() in SpheralPseudoScript). It seems the DataBase pointer is trying to reinitialize neighbors and getting the smoothing kernel extent runs into a segfault. |
|
I've changed the interfaces to several hydro packages, so SpheralC will
have to be updated.
…On Thu, Aug 29, 2024, 1:28 PM Paul Tsuji ***@***.***> wrote:
@jmikeowen <https://github.com/jmikeowen> when I built this branch with
SpheralC tests, the Taylor impact tests will croak in the call to
spheral_initialize_boundaries_and_physics() (or
initializeBoundariesAndPhysics() in SpheralPseudoScript). It seems the
DataBase pointer is trying to reinitialize neighbors and getting the
smoothing kernel extent runs into a segfault.
—
Reply to this email directly, view it on GitHub
<#302 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCN6BTF6ZYGX7QCYCY6DD3ZT5Y7TAVCNFSM6AAAAABM6TFBN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJYG4YTKNRRHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
- Making ASPH only require Voronoi cells when using IdealH. Potentially pretty big time savings for pure IntegrateH mode. - Adding an optional function hook to modify the final ideal H calculation from user scripts.
… all GCC builds to avoid symbols overflows during compilation
…nments which is explicitly what we want for PYB11 targets
specialized user-overridable functor for the ASPH ideal H user filter. I've also excluded surface points from the ideal H replacement as well. With these changes we can now run 2D slab ablation problems well using IntegrateH or IdealH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ToDo :
RELEASE_NOTES.mdwith notable changes.