v2024.06.0 Release #280
Merged
v2024.06.0 Release #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing GHLLC (depricate), adding a ArtificialViscosity implementation for direct comparison in the GSPH paper. Might need to rename to make it less confusing with the AV class heirarchy in Spheral
update policy is now used to handle the Riemann gradients that are stored between steps. for problems with const bc and initial pressure gradients (hydrostatic atmospheres etc...) the pressure gradient will need to be given initial conditions similar to eps or rho or any other field
…ty gradient on start up
this commit removes the isFirstCycle switch which I was using to hackishly initialize the spatial derivatives. When switching over to using the initializeOnStartUp method the switch never flipped messing up the gradients.
GSPH update
Feature/flexible python targets
…to bugfix/PalphaConstructor
Update Spack to 0.22
Bugfixes for P-alpha constructor and ASPH algorithm
CMake docs target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary