Devops/docker envs #271
Merged
Devops/docker envs #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v2024.01.1 Patch Release
… to ubuntu20.04; copying x86_64 to generic dir; Adding concretizer options for generic architecture targeting w/docker builds.
…generating our host-config file.
ldowen
reviewed
Mar 28, 2024
| if sexe("{0} dev-build --fresh --quiet --deprecated -u initconfig {2}@develop%{3} 2>&1 | tee -a \"dev-build-{3}-out.txt\"".format(spack_cmd, os.getcwd(), package_name, s), echo=True) : sys.exit(1) | ||
|
|
||
| # Install only the dependencies for Spheral | ||
| if sexe("{0} install --fail-fast --fresh --deprecated --only dependencies {2}@develop%{3} 2>&1 | tee -a \"dev-build-{3}-out.txt\"".format(spack_cmd, os.getcwd(), package_name, s), echo=True) : sys.exit(1) |
There was a problem hiding this comment.
Why wasn't this install call needed before?
There was a problem hiding this comment.
dev-build acts the same as install in regards to concretizing and installing dependencies, but dev-build doesn't have the --fail-fast option. So here we have spack install only the dependencies with install, then let it create the host-config file from dev-build with our local repo. Using install tries to pull spheral develop and that isn't what we want for tpl-manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a refactor
It does the following:
x86_64/packages.yamlpath toUbuntu20.04/packages.yamlsince that is the operating system the file is configured for.generic/directory for external users to modify for their systems.genericconfig files for a system.spack arch -oto determine operating system and version string when$SYS_TYPEis not availableAdditional Changes:
<install_prefix>/lib/pythonX.Y/site-packages/Spheral. This is standard practice for python library install structures. I Also ran into a bug where my filesystem on MacOS would confuse theSpheral/dir and thespheralexecutable file in our installation dir.Docs: https://spheral.readthedocs.io/en/devops-docker-envs/index.html
ToDo :
RELEASE_NOTES.mdwith notable changes.