layers: Fix Layout Set Compatible check #8647
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 270698. |
| if ((set >= a->set_compat_ids.size()) || (set >= b->set_compat_ids.size())) { | ||
| return false; | ||
| } | ||
| return *(a->set_compat_ids[set]) == *(b->set_compat_ids[set]); |
There was a problem hiding this comment.
This was return a->set_compat_ids[set] == b->set_compat_ids[set]; before which was wrong, it was only checking the shared pointers were different, not that they had different contents
There was a problem hiding this comment.
(plenty of Device Generated Commands tests are coming, they were failing for this reason I learned)
There was a problem hiding this comment.
This was
return a->set_compat_ids[set] == b->set_compat_ids[set];before which was wrong, it was only checking the shared pointers were different, not that they had different contents
I have dejavu we fixed this some time ago.
|
CI Vulkan-ValidationLayers build # 17671 running. |
|
CI Vulkan-ValidationLayers build # 17671 passed. |
there were some VUs in #8605 that needed this fix