Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing VK_EXT_device_generated_commands checks #8605

Open
1 of 28 tasks
spencer-lunarg opened this issue Sep 26, 2024 · 0 comments
Open
1 of 28 tasks

Missing VK_EXT_device_generated_commands checks #8605

spencer-lunarg opened this issue Sep 26, 2024 · 0 comments
Assignees
@spencer-lunarg
Labels
GPU-AV GPU Assisted Validation Incomplete Missing Validation VUs to be added

Comments

@spencer-lunarg
Copy link
Contributor

spencer-lunarg commented Sep 26, 2024 •
edited
Loading

#8604 added most VUs, some (mostly GPU-AV) were not added in the initial release and are tracked here

GPU-AV

  • VUID-vkCmdExecuteGeneratedCommandsEXT-* (all common draw VUs)
  • VUID-vkCmdExecuteGeneratedCommandsEXT-preprocessAddress-11142
  • VUID-VkBindIndexBufferIndirectCommandEXT-None-11117
  • VUID-VkBindIndexBufferIndirectCommandEXT-bufferAddress-11118
  • VUID-VkBindIndexBufferIndirectCommandEXT-None-11119
  • VUID-VkBindVertexBufferIndirectCommandEXT-None-11120
  • VUID-VkBindVertexBufferIndirectCommandEXT-None-11121
  • VUID-VkDrawIndirectCountIndirectCommandEXT-None-11122
  • VUID-VkDrawIndirectCountIndirectCommandEXT-None-11123
  • VUID-VkGeneratedCommandsInfoEXT-indirectCommandsLayout-11065
  • VUID-VkGeneratedCommandsInfoEXT-indirectCommandsLayout-11066
  • VUID-VkGeneratedCommandsInfoEXT-sequenceCountAddress-11068

fine grain sync required

  • VUID-vkUpdateIndirectExecutionSetPipelineEXT-None-11038
  • VUID-VkWriteIndirectExecutionSetPipelineEXT-index-11029
  • VUID-VkWriteIndirectExecutionSetShaderEXT-index-11034
  • VUID-vkCmdExecuteGeneratedCommandsEXT-isPreprocessed-11046
  • VUID-vkCmdExecuteGeneratedCommandsEXT-isPreprocessed-11048
  • VUID-vkCmdExecuteGeneratedCommandsEXT-isPreprocessed-11049
  • VUID-vkCmdExecuteGeneratedCommandsEXT-isPreprocessed-11051
  • VUID-vkCmdExecuteGeneratedCommandsEXT-isPreprocessed-11052
  • VUID-vkCmdExecuteGeneratedCommandsEXT-isPreprocessed-11055 (queue submit update helper)

Layout Compatibility

Need to clean up IsPipelineLayoutSetCompat and DescribeDifference to be used here (done in #8647)

  • VUID-vkUpdateIndirectExecutionSetPipelineEXT-None-11039
  • VUID-vkUpdateIndirectExecutionSetShaderEXT-pExecutionSetWrites-11140
  • VUID-VkWriteIndirectExecutionSetPipelineEXT-pipeline-11028 (https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/6926)
  • VUID-VkGeneratedCommandsInfoEXT-indirectCommandsLayout-11144

Misc

// these the same? (when to track?)

  • VUID-vkCmdExecuteGeneratedCommandsEXT-isPreprocessed-11149
  • VUID-vkCmdExecuteGeneratedCommandsEXT-isPreprocessed-11150

// same as VUID-VkGeneratedCommandsInfoEXT-indirectCommandsLayout-11002?

  • VUID-vkCmdExecuteGeneratedCommandsEXT-indirectCommandsLayout-11004
@spencer-lunarg spencer-lunarg added Incomplete Missing Validation VUs to be added GPU-AV GPU Assisted Validation labels Sep 26, 2024
@spencer-lunarg spencer-lunarg self-assigned this Sep 26, 2024
This was referenced Oct 3, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spencer-lunarg spencer-lunarg

Labels
GPU-AV GPU Assisted Validation Incomplete Missing Validation VUs to be added
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spencer-lunarg