Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpu: Defer GPL instrumenation until linking #8468

Merged
merged 1 commit into from
Sep 18, 2024
Merged

gpu: Defer GPL instrumenation until linking #8468

merged 1 commit into from
Sep 18, 2024

Conversation

spencer-lunarg
Copy link
Contributor

For #8459

Currently a little rough, if this works well, will want to cleanup the somewhat duplicate code path (already wanted to do it with shader object path)

@spencer-lunarg spencer-lunarg requested a review from a team as a code owner August 28, 2024 13:58
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 245030.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17336 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17336 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 246414.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17348 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17348 passed.

@spencer-lunarg spencer-lunarg mentioned this pull request Sep 2, 2024
Merged
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 258551.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17500 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17500 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 258572.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17501 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17501 passed.

arno-lunarg
arno-lunarg approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@arno-lunarg arno-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no need to address my complaints in the test now, it was more of a global rant about some problems I think we have

layers/gpu/instrumentation/gpu_shader_instrumentor.cpp Show resolved Hide resolved
layers/gpu/instrumentation/gpu_shader_instrumentor.cpp Outdated Show resolved Hide resolved
layers/gpu/instrumentation/gpu_shader_instrumentor.cpp Outdated Show resolved Hide resolved
layers/gpu/instrumentation/gpu_shader_instrumentor.cpp Outdated Show resolved Hide resolved
layers/gpu/instrumentation/gpu_shader_instrumentor.cpp Outdated Show resolved Hide resolved
layers/gpu/instrumentation/gpu_shader_instrumentor.cpp Outdated Show resolved Hide resolved
tests/unit/gpu_av_oob.cpp Outdated Show resolved Hide resolved
tests/unit/gpu_av_oob.cpp Outdated Show resolved Hide resolved
tests/unit/gpu_av_oob.cpp Outdated Show resolved Hide resolved
tests/unit/gpu_av_oob.cpp Outdated Show resolved Hide resolved
@spencer-lunarg
Copy link
Contributor Author

no need to address my complaints in the test now

I need to make the other nit updates (also realized one more test I want to add) so happy to do it... but agree it is quite a mess and we only copy-and-paste it around like wild fire

@spencer-lunarg spencer-lunarg mentioned this pull request Sep 18, 2024
Open
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 258839.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17504 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17504 passed.

@spencer-lunarg spencer-lunarg merged commit dea352a into KhronosGroup:main Sep 18, 2024
21 checks passed
@spencer-lunarg spencer-lunarg deleted the spencer-lunarg-gpl-defer branch September 18, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arno-lunarg arno-lunarg arno-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spencer-lunarg @ci-tester-lunarg @arno-lunarg