Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

14 Move file url function to api route #1426

Merged
merged 2 commits into from
Oct 1, 2024
Merged

14 Move file url function to api route #1426

merged 2 commits into from
Oct 1, 2024

Conversation

FabianDevel
Copy link
Contributor

Depends on #1425

Move all the computing URL logic from File class to ApiRoutes with the rest of the URL

@FabianDevel FabianDevel added enhancement New feature or request quick A pull request consisting of a few lines labels Sep 19, 2024
@github-actions github-actions bot added the dependent This MR depends on another PR label Sep 19, 2024
@FabianDevel FabianDevel mentioned this pull request Sep 19, 2024
Merged
@tevincent
Copy link
Contributor

Capture d’écran 2024-09-20 à 13 29 29

@FabianDevel FabianDevel mentioned this pull request Sep 20, 2024
Merged
tevincent
tevincent requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@tevincent tevincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

131

@FabianDevel FabianDevel force-pushed the 14-Move-file-url-function-to-apiRoute branch 2 times, most recently from 23c4666 to 85d7e94 Compare October 1, 2024 12:09
Base automatically changed from 13-fix-pagination-bug to public-shares-feature October 1, 2024 12:10
@github-actions github-actions bot removed the dependent This MR depends on another PR label Oct 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

This PR/issue depends on:

@FabianDevel FabianDevel force-pushed the 14-Move-file-url-function-to-apiRoute branch from 85d7e94 to fc57e93 Compare October 1, 2024 12:17
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@FabianDevel FabianDevel merged commit d538d7b into public-shares-feature Oct 1, 2024
4 checks passed
@FabianDevel FabianDevel deleted the 14-Move-file-url-function-to-apiRoute branch October 1, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirambd sirambd sirambd approved these changes

@tevincent tevincent tevincent approved these changes

Assignees

@FabianDevel FabianDevel

Labels
enhancement New feature or request quick A pull request consisting of a few lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FabianDevel @tevincent @sirambd