Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15 Refactor executeDownloadActions #1427

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

FabianDevel
Copy link
Contributor

Depends on #1426

Better separation of Ui logic and ViewModel by removing UI logic's callback from viewModel's function

@FabianDevel FabianDevel added the enhancement New feature or request label Sep 19, 2024
@github-actions github-actions bot added the dependent This MR depends on another PR label Sep 19, 2024
@FabianDevel FabianDevel force-pushed the 14-Move-file-url-function-to-apiRoute branch from 0573f0f to 23c4666 Compare October 1, 2024 11:40
@FabianDevel FabianDevel force-pushed the 15-refactor-executeDownloadActions branch from 0e5c8cb to 2b86b00 Compare October 1, 2024 11:40
@FabianDevel FabianDevel force-pushed the 14-Move-file-url-function-to-apiRoute branch 2 times, most recently from 85d7e94 to fc57e93 Compare October 1, 2024 12:17
@FabianDevel FabianDevel force-pushed the 15-refactor-executeDownloadActions branch from 2b86b00 to 0db036d Compare October 1, 2024 12:21
Base automatically changed from 14-Move-file-url-function-to-apiRoute to public-shares-feature October 1, 2024 12:23
@github-actions github-actions bot removed the dependent This MR depends on another PR label Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

This PR/issue depends on:

@FabianDevel FabianDevel force-pushed the 15-refactor-executeDownloadActions branch from 0db036d to 2b1511e Compare October 1, 2024 12:28
@FabianDevel FabianDevel force-pushed the 15-refactor-executeDownloadActions branch from af27dfb to bc6a642 Compare October 1, 2024 13:05
@sirambd sirambd enabled auto-merge October 1, 2024 13:14
Copy link

sonarcloud bot commented Oct 1, 2024

@sirambd sirambd merged commit 21f0316 into public-shares-feature Oct 1, 2024
4 checks passed
@sirambd sirambd deleted the 15-refactor-executeDownloadActions branch October 1, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants